fix(lifecycle-operator): remove hardcoded keptn namespace #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: realanna <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2141 +/- ##
==========================================
+ Coverage 84.44% 84.47% +0.03%
==========================================
Files 150 151 +1
Lines 9634 9728 +94
==========================================
+ Hits 8135 8218 +83
- Misses 1217 1223 +6
- Partials 282 287 +5
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
force-pushed
the
fix/hardcoded_namespace
branch
from
7618453 to
c4075eb
Compare
Signed-off-by: realanna <[email protected]>
RealAnna
force-pushed
the
fix/hardcoded_namespace
branch
from
572c1f0 to
0cf7d74
Compare
Signed-off-by: realanna <[email protected]>
RealAnna
changed the title
odubajDT
reviewed
Sep 21, 2023
lifecycle-operator/controllers/common/providers/keptnmetric/keptnmetric_test.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 21, 2023
odubajDT
reviewed
Sep 21, 2023
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 21, 2023
lifecycle-operator/test/component/appversion/appversion_suite_test.go
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 21, 2023
odubajDT
reviewed
Sep 21, 2023
lifecycle-operator/test/component/workloadinstance/workloadinstance_suite_test.go
Outdated
Show resolved
Hide resolved
|
as a follow up we could consider making the default namespace accessible via this config component: https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/controllers/common/config/config.go |
Did not even know we had that 😻 I think I will adapt it now |
Signed-off-by: realanna <[email protected]>
bacherfl
previously approved these changes
Sep 21, 2023
odubajDT
previously approved these changes
Sep 21, 2023
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
bacherfl
reviewed
Sep 21, 2023
Signed-off-by: realanna <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Sep 21, 2023
bacherfl
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
RealAnna
added a commit
that referenced
this pull request
Sep 27, 2023
Signed-off-by: realanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2139 removing hardcoded references to namespace